Use atomic.Pointer to prevent race condition in bccsp.Factory#48
Merged
Conversation
liran-funaro
force-pushed
the
atomic-factory
branch
2 times, most recently
from
bdbffce to
99aa359
Compare
pfi79
requested changes
Mar 24, 2026
pfi79
left a comment
pfi79
left a comment
Contributor
There was a problem hiding this comment.
-
In the fabric project, it is customary for import sections to consist of 2 sections rather than 3.
-
You definitely need to check the performance of your changes on fabric itself. That is, make a fork of fabric, replace fabric-lib-go with your own version, and run all fabric tests.
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
liran-funaro
force-pushed
the
atomic-factory
branch
from
99aa359 to
555abfb
Compare
Contributor
Author
|
@pfi79 Thanks for the quick review. |
pfi79
approved these changes
Mar 24, 2026
Contributor
|
I have released a new v1.1.3 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses atomic.Pointer to prevent race condition in bccsp.Factory.